Commit Graph

12044 Commits

Author SHA1 Message Date
Anton Georgiev
5a878c6526
Merge pull request #18503 from ramonlsouza/native-debounce
refactor: replace debounce function
2023-08-10 09:58:11 -04:00
Anton Georgiev
2e80e406b9
Merge pull request #18469 from ramonlsouza/keyboard-reactions
style: reactions bar improvements
2023-08-10 09:55:30 -04:00
Gustavo Trott
456950a800
Merge pull request #18459 from GuiLeme/issue-18446
fix: download of original presentation
2023-08-10 10:37:11 -03:00
Anton Georgiev
20ea8da9f7
Merge pull request #18460 from ramonlsouza/issue-18437
fix: Display raise hand and away emoji in userlist
2023-08-09 17:19:58 -04:00
Ramón Souza
3bde4c970e
Merge pull request #18456 from ramonlsouza/issue-18434
fix: Labels flowing out of a <div> in breakout rooms creation view
2023-08-09 15:59:14 -03:00
Ramón Souza
38c6da7c29 add comment about debounce function 2023-08-09 15:42:21 -03:00
Ramón Souza
835bbd4733 replace unaffected debounce 2023-08-09 13:26:42 -03:00
Ramón Souza
80094581f6 replace leading:true, trailing: false debounces 2023-08-09 13:12:29 -03:00
Ramón Souza
7fee4d5f95 replace mute debounce 2023-08-09 13:06:57 -03:00
Ramón Souza
c55a9b43b3 add debounce function 2023-08-09 13:06:27 -03:00
prlanzarin
b8a1b881c5 fix(audio): clear connection timeout on autoplay failures
If the autoplay block is triggered in listen only, the connection timer
keeps ticking even if the user correctly accepts the audio play prompt.
That causes an audio re-connect once the timeout expires.

Clear the connection timer if the audio bridge starts with
NotAllowedError as a soft error. For connection purposes, the audio join
procedure worked. The autoplay thing is at the UI/UX level, not WebRTC.
2023-08-09 11:09:27 -03:00
Ramón Souza
e767a39799 centralize emoji, add focus color 2023-08-08 15:28:05 -03:00
Anton Georgiev
67b7b2a3a4
Merge pull request #18464 from gustavotrott/fix-same-reaction-twice-in-a-row
fix (html5): Unable to choose same Reaction emoji twice in a row
2023-08-08 12:46:11 -04:00
Anton Georgiev
7f6b7b2e74
Merge pull request #18447 from ramonlsouza/keyboard-reactions
fix(access): keyboard navigation in reactions bar
2023-08-08 12:16:48 -04:00
Gustavo Trott
eaf86b37a8 Fix: Unable to choose same reaction twice in a row 2023-08-08 11:32:52 -03:00
Paulo Lanzarin
d7e9cb05ee
Merge pull request #18461 from prlanzarin/u27/feat/transparent-listen-only
feat(audio): add experimental transparent listen only mode
2023-08-08 09:39:12 -03:00
prlanzarin
8feb934169 feat(audio): add experimental transparent listen only mode
This is an initial, experimental implementation of the feature proposed in
https://github.com/bigbluebutton/bigbluebutton/issues/14021.

The intention is to phase out the explicit listen only mode with two
overarching goals:
  - Reduce UX friction and increase familiarity: the existence of a separate
  listen only mode is a source of confusion for the majority of users
  Reduce average server-side CPU usage while also making it possible for
  having full audio-only meetings.

The proof-of-concept works based on the assumption that a "many
concurrent active talkers" scenario is both rare and not useful. With
that in mind, this including two server-side triggers:
 - On microphone inactivity (currently mute action that is sustained for
   4 seconds, configurable): FreeSWITCH channels are held (which translates
   to much lower CPU usage, virtually 0%). Receiving channels are switched,
   server side, to a listening mode (SFU, mediasoup).
   * This required an extension to mediasoup two allow re-assigning producers
     to already established consumers. No re-negotiation is done.
 - On microphone activity (currently unmute action, immediate):
   FreeSWITCH channels are unheld, listening mode is deactivated and the
   mute state is updated accordingly (in this order).

This is *off by default*. It needs to be enabled in two places:
  - `/etc/bigbluebutton/bbb-webrtc-sfu/production.yml` ->
    `transparentListenOnly: true`
  - End users:
    * Server wide: `/etc/bigbluebutton/bbb-html5.yml` ->
      `public.media.transparentListenOnly: true`
    * Per user: `userdata-bbb_transparent_listen_only=true`
2023-08-07 19:43:18 -03:00
Ramón Souza
9f2276b668 only display emoji if reactions are enabled 2023-08-07 17:02:49 -03:00
Ramón Souza
cc09894924 add raise hand and away emoji in userlist 2023-08-07 16:49:03 -03:00
Ramón Souza
c68da552d2 break lines in breakout room checkbox 2023-08-07 11:34:35 -03:00
GuiLeme
ce22c1894d [issue-18446] - fix download of original presentation 2023-08-04 17:38:17 -03:00
Ramón Souza
56c4657c46 adjust styles 2023-08-04 16:14:57 -03:00
Ramón Souza
1aba53885b
Merge pull request #18439 from Scroody/I-17970
fix: Disabled self cam tied to specific cam (or all cams)
2023-08-04 15:25:58 -03:00
Anton Georgiev
2fcbd31a42
Merge pull request #18427 from ramonlsouza/guest-updates
fix: Notify guest policy change
2023-08-04 10:39:57 -04:00
imdt
14c83bb6d3 Adjustments 2023-08-04 10:41:07 -03:00
Ramón Souza
87e2e88f6c
Merge pull request #18440 from Scroody/margin-to-talking-indicator
style: Margin of talking indicator adjusted to better fitting size
2023-08-03 16:18:20 -03:00
Ramón Souza
8802d8fffd
Merge pull request #18448 from Scroody/margin-to-timer2
style: Margin of timer adjusted to better fitting size
2023-08-03 16:18:09 -03:00
André Castro
163e18b8a3
Adjustments to the timer 2023-08-03 16:15:46 -03:00
Ramón Souza
4da6bb2864
Merge pull request #18441 from Scroody/margin-to-timer
Client: Margin of timer adjusted to better fitting size
2023-08-03 15:56:25 -03:00
Paulo Lanzarin
5ddf3155c7
Merge pull request #18407 from prlanzarin/u27/fix/audio-retry-timeout-logs
feat(audio): add retryThroughRelay, +...
2023-08-03 15:50:04 -03:00
Ramón Souza
95e3bba2f1 make reactions bar accessible by keyboard 2023-08-03 15:48:47 -03:00
imdt
44a0c2d10c Client: Margin of timer adjusted to better fitting size 2023-08-03 11:48:00 -03:00
imdt
08de342179 Adjustment 2023-08-03 11:32:27 -03:00
imdt
d843b8df56 Client: Margin adjusted to better fitting size 2023-08-03 11:29:51 -03:00
imdt
205d1d5f35 Fix: disabled self cam tied to specific cam or all 2023-08-02 17:59:19 -03:00
Ramón Souza
e0e68f3896 guest policy change toast 2023-08-02 13:22:43 -03:00
Ramón Souza
d960ccb1c9
Merge pull request #18399 from Scroody/fix-pulse-animation-with-avatar
Fix: pulse animation with avatar
2023-08-02 08:47:33 -03:00
Ramón Souza
df8e9e9440 split disabled download of presentation params 2023-07-31 17:03:29 -03:00
prlanzarin
a8e4e876d0 fix(audio): add connection timers for SFU audio
SFU based audio is missing connection timers, which means the join
procedure can go on indefinitely in a couple of scenarios.

Refactor the connection timers added for re-connections in the SFU audio
bridge and make them valid for the first try as well.

Make 1010 errors (connection timeout) retriable when retryThroughRelay
is enabled.
2023-07-31 11:39:52 -03:00
prlanzarin
7c3ac51e38 feat(audio): add retryThroughRelay flag for 1007 errors
1007 errors are still a large fraction of our overall audio join error
rate. This usually indicates some sort of firewall block or UDP issues
carrier networks. I can't figure out why some scenarios won't trickle
down to relay candidates though - I'm leaning to scenarios where STUN
packets with USE-CANDIDATE are being mangled/lost along the way or
something else that borks the (already fragile) conn checks for ICE-lite
implementations.

Add a new feature called retryThroughRelay which triggers a retry with
iceTransportPolicy=relay whenever audio fails to join with a 1007 error.
The goal is to force relay usage to try and bypass 1007s scenarios that
still happen.

Disabled by default.
2023-07-31 11:39:45 -03:00
prlanzarin
26815f4679 chore(audio): add more data to audio_joined/failure logs
Add secondsToActivateAudio, inputDeviceId, outputDeviceId and isListenOnly
to audio_joined.extraInfo

Add inputDeviceId, outputDeviceId and isListenOnly to
audio_failure.extraInfo

Add a try-catch to the device enforcement procedure triggered by
onAudioJoin - it may throw and block the modal.
2023-07-31 11:39:24 -03:00
Scroody
0a9b061434 Fix: Pulsing animation not working with avatar 2023-07-28 13:31:44 -03:00
Ramón Souza
bd97a008a0 fix hide presentation on join 2023-07-27 15:49:21 -03:00
Ramón Souza
8e0b48e8be
Merge pull request #18164 from Arthurk12/bbb-wake-locke
feat: Screen wake lock feature
2023-07-27 10:58:05 -03:00
Anton Georgiev
7be38fd876 Merge remote-tracking branch 'bbb/v2.6.x-release' into merge-july26 2023-07-26 22:27:55 -04:00
Arthurk12
7b57565fc5 fix(wake-lock): settings attribute name 2023-07-26 17:38:34 -03:00
Anton Georgiev
9611df968d
Merge pull request #18385 from gustavotrott/fix-dial-in-user-invisible
fix: Dial-in users not in list
2023-07-26 15:17:42 -04:00
Tainan Felipe
838accf015 Improve text sanitizing of lobby messages 2023-07-26 16:12:39 -03:00
Anton Georgiev
ce2b65798b
Merge pull request #18377 from antonbsa/parameter-tests-fix-after-merge
test: Parameter tests fix
2023-07-26 14:05:18 -04:00
Anton B
1024930a32 test: disabled features test fixes and managePresentationButton selector update 2023-07-25 15:26:42 -03:00