Commit Graph

27033 Commits

Author SHA1 Message Date
Fred Dixon
04959f45d8
Merge pull request #10841 from lkiesow/allow-bbb-to-manage-rec
Allow user bigbluebutton to delete recordings
2020-11-16 19:49:46 -05:00
Lars Kiesow
7a59069958
Allow user bigbluebutton to delete recordings
This patch modifies `bbb-record` allowing the user `bigbluebutton` to
delete recordings. The user has all necessary access rights, meaning
that the deletion works without a problem and the check for root does
not protect anything. The users owns the data after all. The current
check just makes things less convenient.
2020-11-16 23:58:47 +01:00
Anton Georgiev
18b7528571
Merge pull request #10824 from antobinary/debug-behind-flag
Pulled HTML5 locales on Nov 13, 2020
2020-11-13 14:18:47 -05:00
Anton Georgiev
9ed5154740 Pulled HTML5 locales on Nov 13, 2020 2020-11-13 14:17:15 -05:00
Anton Georgiev
b1227f5785
Merge pull request #10810 from prlanzarin/u22-gumtgc-wa
[html5/webrtc] Fix tryGenerateIceCandidates rejections and put it behind a flag
2020-11-13 11:00:05 -05:00
Anton Georgiev
ecbf575dcf
Merge pull request #10819 from bigbluebutton/join-api-sanitize
Sanitize parameters of API's. Fixes #10818
2020-11-13 10:55:38 -05:00
Anton Georgiev
ca0adf046c
Merge pull request #10820 from bigbluebutton/clear-return-messages
Split error message from session token in bbb-web enter API
2020-11-13 10:45:11 -05:00
Anton Georgiev
72b4c83844
Merge pull request #10817 from antobinary/debug-behind-flag
Simplified redis debug and placed behind check
2020-11-13 09:53:26 -05:00
Tiago Daniel Jacobs
e59bcd0c33 Sanitize all received parameters 2020-11-13 06:54:32 +00:00
Tiago Daniel Jacobs
52e3eea552 Split error message from session token ( making it easier to translate - and more secure/ ) 2020-11-13 06:13:48 +00:00
Tiago Daniel Jacobs
5c911ddeec Sanitize fullName parameter of join API. Fixes #10818 2020-11-13 05:59:31 +00:00
Anton Georgiev
a8dc7a0bff Simplified redis debug and placed behind check 2020-11-12 21:03:57 -05:00
Fred Dixon
cafe1a53ce
Merge pull request #10816 from mariogasparoni/v2.2.x-release
Increase private key size for dtls-srtp.pem to 4096
2020-11-12 15:29:32 -05:00
Mario Jr
ebe9b3a789 Increase private key size for dtls-srtp.pem to 4096
Using this larger value helps reducing ocurrences 1005/1010 errors for Chrome, avoiding an openssl's error which interrupts the dtls handshake (Chrome triggers "DTLS timeout expired" error)
This key size is also the default value used by freeswitch on switch_core_cert.c
2020-11-12 16:59:45 -03:00
prlanzarin
8dda22f8a7 [html5/webrtc] Fix tryGenerateIceCandidates rejections, put it behind a flag
Fixed two occurrences where the tryGenerateIceCandidates workaround rejected without an error, which borked the callers error handling

Also put it behind a config flag. This workaround used to be important when Kurento didnt infer prflx candidates properly, but that`s no longer the case. With the flag, we can disable the workaround to see if there`s any visible regression and hopefully remove it down the road
2020-11-11 13:43:36 +00:00
Fred Dixon
fb96ffdc00
Merge pull request #10808 from prlanzarin/u22-1002-6-wa
[html5/audio] Add a configurable hackViaWs to SIP.js. Part of a workaround for #9667
2020-11-10 13:39:59 -05:00
prlanzarin
a1f0276b64 [html5/audio] Add hackViaWs to SIP.js and make it configurable in settings.yml, 1002 workaround
This adds the possibility to configure the SIP Via header to plain WS to allow reverse proxying from WSS to WS, internally, to work around a bug in freeswitch where the WSS stack would get deadlocked due to a still unidentified bug in there that has to do with SSL termination
2020-11-10 15:04:45 +00:00
Fred Dixon
6383af3667
Merge pull request #10806 from mariogasparoni/v2.2.x-release
Force using plan-b as default sdpSemantics for chrome
2020-11-09 20:03:48 -05:00
Mario Jr
b948bea11b Force using plan-b as default sdpSemantics for chrome
Although Chrome's default is now unified plan, Chrome <-> FreeSWITCH ICE connection fails for some Chrome installations (specially those running on Windows).
FS ICE fails when Chromes's SDP has "a=mid:<index>" (instead of "a=mid:audio").
This fixes Error 1010 and situations where echo test takes too long.
This fixes #6414 regression, once we do the same older version of SIP.js used to do.
2020-11-09 21:58:16 -03:00
Fred Dixon
a74f62ef44
Merge pull request #10800 from mariogasparoni/v2.2.x-release
Use iceConnectionState to monitor ICE connection status
2020-11-09 06:59:04 -05:00
Mario Jr
46e0c263fe Use iceConnectionState to monitor ICE connection status
We now use both peer's connectionstatechange and iceconnectionstatechange to monitor ICE state for audio sessions.
The same way we did with old sip.js version, we leave iceconnectionstate trigger audio actions , such as connect, disconnect, reconnect.
We still listen for 'failed' state for connectionstatechange event, because chrome triggers this (tested on 86+).
This should reduce the audio error 1010 ocurrences, once some browsers (specially Chrome/Android) don't trigger connectionstatechangeevent.
This might reduce problems reported in #10708, which still needs more investigation though.
2020-11-08 22:43:52 -03:00
Fred Dixon
83dfc99260
Merge pull request #10799 from jarmediagmbh/my-changes-branch
Remove unwanted debug logging of PDF binaries
2020-11-08 17:52:50 -05:00
Your Name
b4ecf53c80 Remove unwanted debug logging: This pushed the whole binary of every PDF uploaded into the logs. 2020-11-08 16:56:26 +01:00
Fred Dixon
97da7d6023
Merge pull request #10704 from KDSBrowne/2.2-upload-modal-error-bound
Add error boundary to presentation upload modal
2020-11-06 16:40:50 -05:00
Richard Alam
e28bba42fc
Merge pull request #10742 from KDSBrowne/2.2-issue-10705
Prevent users from sending multiple votes per poll
2020-11-06 16:33:56 -05:00
Fred Dixon
7ba1ce721b
Merge pull request #10790 from mariogasparoni/v2.2.x-release
Correctly Map Websocket error and better monitoring of ICE events
2020-11-06 08:50:27 -05:00
Mario Jr
3a689578c6 Monitor peer's iceconnectionstatechange event
This gives more information about ICE connection, combined with onconnectionstatechange event
2020-11-06 09:37:58 -03:00
Mario Jr
2585d957e8 Correctly map WebSocket error
Maps WebSocket's 1006 error to BBB's 1002, the same way it was done with old sip.js version
Set user agent's number of reconnection attempts to the same value as older sip.js version
2020-11-06 09:25:40 -03:00
KDSBrowne
50f85ff2e2 make responders private | add accessors 2020-11-05 19:24:10 +00:00
KDSBrowne
2468ac225c return null in publishVote if user already voted 2020-11-05 17:02:31 +00:00
KDSBrowne
5076a2accd fix typo / use operator / add log 2020-11-05 14:19:36 +00:00
Anton Georgiev
6fe983af6d
Merge pull request #10754 from KDSBrowne/2.2-issue-10748
Fix presentation downloadable tooltip label
2020-10-30 09:47:45 -04:00
KDSBrowne
7c690ab22c fix presentation downloadable tooltip msg 2020-10-30 13:00:07 +00:00
KDSBrowne
d2cb02b3bd prevent users from being able to send more than 1 poll vote 2020-10-28 18:33:09 +00:00
Anton Georgiev
b17f54283a
Merge pull request #10741 from mariogasparoni/v2.2.x-release
Properly stops userAgent / peer when audio connection/reconnection fails
2020-10-28 14:13:14 -04:00
Mario Jr
3e3b648040 Properly stops userAgent / peer when audio connection/reconnection fails
Changed the maximum attempts of the UserAgent reconnection (this should be changed when binding audio's websocket to meteor's connection state).
Added a log to monitor WS reconnect attempts.
2020-10-28 15:04:30 -03:00
Anton Georgiev
8966fbf89a
Merge pull request #10718 from mariogasparoni/v2.2.x-release
Prevent 1005 error log when user close/reload bbb's window/tab
2020-10-26 10:37:30 -04:00
Mario Jr
d1e5f189ba Prevent 1005 error log when user close/reload bbb's window/tab
When closing/reloading tab with active microphone, audio exits successfully but a wrong log-error (1005) is shown.
We now process closing/reloading tab the same way we do when user hangup the call.
2020-10-25 16:12:58 -03:00
Anton Georgiev
e63c49e515
Merge pull request #10716 from mariogasparoni/v2.2.x-release
Change default value of iceGatheringTimeout to current's SIP.js default
2020-10-24 08:27:35 -04:00
Mario Jr
18c20261e1 Change default value of iceGatheringTimeout to current's SIP.js default
For some reason (still investigating), using turn/coturn on 443/tcp makes firefox's iceGathering process (during echo test) takes 12+ seconds (tested on webrtc's trickle page with multiple instances).
This was found when testing the current default (15s) on production with a private turn/coturn server on port 443/tcp. For default bbb setup (stun only), echo test still runs fast.
To avoid adding extra delay to iceGathering on this scenario (Firefox + turn on 443/tcp), i am just setting the default value back to the 5s (old default).
So , for those who wants to reduce the 1004 occurrences, increasing the iceGatheringTimeout could help (just be aware this adds delay on the mentioned scenario).
2020-10-24 08:58:25 -03:00
Anton Georgiev
49c7800266
Merge pull request #10714 from mariogasparoni/v2.2.x-release
Audio Improvements
2020-10-23 11:54:15 -04:00
Zh4rsiest
3f13f4eca4 Changing isIphone value
The component expects a boolean but isIphone property return an array ["Iphone"] if the user is from an iPhone
2020-10-23 12:37:43 -03:00
Zh4rsiest
1b7a672a1b Updating variables in container
They both return an array with ["Iphone"] if you're from an iphone but the component expects bool variables.
2020-10-23 12:37:18 -03:00
Fred Dixon
d0bc77c3db Updating stun: for bbb-web to use Google's stun server 2020-10-23 11:26:41 -03:00
Mario Jr
a86ff72aa3 Increase default iceGatheringTimeout
Added a default 'MEDIA' option: iceGatheringTimeout. This option allows admin to set a higher ICE gathering timeout, which can help when getting ICE errors during audio negotiation (eg 1004)
Default value set to 15s (current default is 5s).
2020-10-23 11:21:20 -03:00
Mario Jr
993c3a5a8a Do not show reconnect/disconnect message when new ICE candidates are found
Sometimes, when user already joined audio session, RTCPeerConnection may
find new ICE candidates, which triggers 'connected' state for peer's
'onconnectionstatechange' event. When this happens we process this
new state the same way when user is not running an audio session, which
makes html5client popup an annoying 'Audio Connected' message.
The audio keeps working fine, but this can make user think that there's a
connection issue, or the audio is reconnecting, while audio is ok.
2020-10-23 11:20:08 -03:00
KDSBrowne
e116396481 add error boundry to presentation upload modal 2020-10-22 13:00:09 +00:00
Anton Georgiev
23cd4cfc87
Merge pull request #10692 from lfzawacki/instructure-extra-dot
Dont include extra dot in instructure media url
2020-10-21 13:12:02 -04:00
Lucas Zawacki
7efcd3b87e Dont include extra dot in instructure media url 2020-10-21 14:00:51 -03:00
Anton Georgiev
7df4434c6c
Bump up to 2.2.29 2020-10-21 12:59:21 -04:00