BigBlueButton/bigbluebutton-Github
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #20005 from prlanzarin/u27/fix/crash-getBoundingClientRect-emojirain

Browse Source 
[2.7] fix(reactions): crash when interactionsButton coords are absent
This commit is contained in:
Anton Georgiev 2024-04-12 15:13:33 -04:00 committed by GitHub
commit fda4a5a2ff
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 17 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
bigbluebutton-html5/imports/ui/components/emoji-rain/component.jsx
View File

@ -1,6 +1,7 @@
import React, { useRef, useState, useEffect } from 'react';
import Settings from '/imports/ui/services/settings';
import Service from './service';
import logger from '/imports/startup/client/logger';
const EmojiRain = ({ reactions }) => {
const containerRef = useRef(null);
@ -12,9 +13,16 @@ const EmojiRain = ({ reactions }) => {
const { animations } = Settings.application;
function createEmojiRain(emoji) {
const coord = Service.getInteractionsButtonCoordenates();
const coord = Service.getInteractionsButtonCoordinates();
const flyingEmojis = [];
if (coord == null) {
logger.warn({
logCode: 'interactions_emoji_rain_no_coord',
}, 'No coordinates for interactions button, skipping emoji rain');
return;
}
for (i = 0; i < NUMBER_OF_EMOJIS; i++) {
const initialPosition = {
x: coord.x + coord.width / 8,

12
bigbluebutton-html5/imports/ui/components/emoji-rain/service.js
View File

@ -1,9 +1,13 @@
const getInteractionsButtonCoordenates = () => {
const getInteractionsButtonCoordinates = () => {
const el = document.getElementById('interactionsButton');
const coordenada = el.getBoundingClientRect();
return coordenada;
if (!el) return null;
const coordinate = el.getBoundingClientRect();
return coordinate;
};
export default {
getInteractionsButtonCoordenates,
getInteractionsButtonCoordinates,
};