From 6ec1272a2bef2d8a4fb301358be6e183d353107a Mon Sep 17 00:00:00 2001 From: prlanzarin <4529051+prlanzarin@users.noreply.github.com> Date: Thu, 1 Aug 2024 14:33:52 -0300 Subject: [PATCH] fix(video): camera cannot be shared as content A change in e28a595b525 introduced an issue where the "Share camera as content" modal always has it's "share" action flagged as disabled. This is due to a short-circuit introduced in the initial gUM procedure that does not clear the "disabled" state before exiting. Properly reset the "disabled" sharing state after the initial gUM in video-preview when "Share camera as content" is used, thus fixing the aforementioned issue. --- .../imports/ui/components/video-preview/component.jsx | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/bigbluebutton-html5/imports/ui/components/video-preview/component.jsx b/bigbluebutton-html5/imports/ui/components/video-preview/component.jsx index 1de6943958..4649c23e85 100755 --- a/bigbluebutton-html5/imports/ui/components/video-preview/component.jsx +++ b/bigbluebutton-html5/imports/ui/components/video-preview/component.jsx @@ -735,7 +735,13 @@ class VideoPreview extends Component { this.currentVideoStream = bbbVideoStream; this.updateDeviceId(deviceId); - if (cameraAsContent) return Promise.resolve(true); + if (cameraAsContent) { + this.setState({ + isStartSharingDisabled: false, + }); + + return Promise.resolve(true); + } return this.startEffects(deviceId) .catch((error) => {