BigBlueButton/bigbluebutton-Github
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(audio): broken connection stats on Firefox >= 125

Browse Source 
WebRTC-based stats generation in the connection status modal is broken
on Firefox >= 125. A broken type check coupled with a new partially
implemented RTCIceTransport dictionary causes and undefined function
call when fetching the selected candidate pair. Since that error is
unhandled, collection breaks.

Correctly check for the getSelectedCandidatePair method availability in
RTCIceTransport so that it skips to pair inference from getStats if
necessary.
This commit is contained in:
prlanzarin 2024-04-30 13:44:29 -03:00 committed by Anton Georgiev
parent 289e591edc
commit e4a266ae75
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
bigbluebutton-html5/imports/ui/services/audio-manager/index.js
View File

@ -1054,10 +1054,9 @@ class AudioManager {
receivers[0] &&
receivers[0].transport &&
receivers[0].transport.iceTransport &&
receivers[0].transport.iceTransport
typeof receivers[0].transport.iceTransport.getSelectedCandidatePair === 'function'
) {
selectedPair =
receivers[0].transport.iceTransport.getSelectedCandidatePair();
selectedPair = receivers[0].transport.iceTransport.getSelectedCandidatePair();
}
return selectedPair;