BigBlueButton/bigbluebutton-Github
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(audio): always send unhold

Browse Source 
Alway send the unhold command since it doesn't change flip the state
(contrary to the uuid_hold toggle command).

It's not idempotent, though - so always update the internal hold state
to prevent state mismatches preventing channels from being unheld.
This commit is contained in:
prlanzarin 2024-06-27 21:22:32 -03:00
parent 58ccd9e586
commit ceff20ff21
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
akka-bbb-apps/src/main/scala/org/bigbluebutton/core/apps/voice/ListenOnlyModeToggledInSfuEvtMsgHdlr.scala
View File

@ -25,14 +25,15 @@ trait ListenOnlyModeToggledInSfuEvtMsgHdlr {
// opposite of what we want. // opposite of what we want.
// The unhold (uuid_hold off) command is not affected by this, but we don't // The unhold (uuid_hold off) command is not affected by this, but we don't
// want to send it if the channel is already unheld. // want to send it if the channel is already unheld.
if (msg.body.enabled != vu.hold) { if ((msg.body.enabled && !vu.hold) || !msg.body.enabled) {
VoiceApp.holdChannelInVoiceConf( VoiceApp.holdChannelInVoiceConf(
liveMeeting, liveMeeting,
outGW, outGW,
vu.uuid, vu.uuid,
msg.body.enabled msg.body.enabled
) )
} else { }
// If the channel is already in the desired state, just make sure // If the channel is already in the desired state, just make sure
// any pending mute or unmute commands are sent. // any pending mute or unmute commands are sent.
VoiceApp.handleChannelHoldChanged( VoiceApp.handleChannelHoldChanged(
@ -44,5 +45,4 @@ trait ListenOnlyModeToggledInSfuEvtMsgHdlr {
) )
} }
} }
}
} }