BigBlueButton/bigbluebutton-Github
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #12306 from mariogasparoni/feat-show-audio-filters

Browse Source 
feat(audio): add showAudioFilters option in settings.yml
This commit is contained in:
Anton Georgiev 2021-05-06 11:05:45 -04:00 committed by GitHub
commit cac1758aaf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 49 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

64
bigbluebutton-html5/imports/ui/components/settings/submenus/application/component.jsx
View File

@ -9,6 +9,10 @@ import { styles } from '../styles';
import VideoService from '/imports/ui/components/video-provider/service';
const MIN_FONTSIZE = 0;
const SHOW_AUDIO_FILTERS = (Meteor.settings.public.app
.showAudioFilters === undefined)
? true
: Meteor.settings.public.app.showAudioFilters;
const intlMessages = defineMessages({
applicationSectionTitle: {
@ -204,6 +208,43 @@ class ApplicationMenu extends BaseMenu {
this.handleUpdateSettings('application', obj.settings);
}
renderAudioFilters() {
let audioFilterOption = null;
if (SHOW_AUDIO_FILTERS) {
const { intl, showToggleLabel, displaySettingsStatus } = this.props;
const { settings } = this.state;
const audioFilterStatus = ApplicationMenu
.isAudioFilterEnabled(settings.microphoneConstraints);
audioFilterOption = (
<div className={styles.row}>
<div className={styles.col} aria-hidden="true">
<div className={styles.formElement}>
<span className={styles.label}>
{intl.formatMessage(intlMessages.audioFilterLabel)}
</span>
</div>
</div>
<div className={styles.col}>
<div className={cx(styles.formElement, styles.pullContentRight)}>
{displaySettingsStatus(audioFilterStatus)}
<Toggle
icons={false}
defaultChecked={this.state.audioFilterEnabled}
onChange={() => this.handleAudioFilterChange()}
ariaLabel={intl.formatMessage(intlMessages.audioFilterLabel)}
showToggleLabel={showToggleLabel}
/>
</div>
</div>
</div>
);
}
return audioFilterOption;
}
renderPaginationToggle() {
// See VideoService's method for an explanation
if (!VideoService.shouldRenderPaginationToggle()) return;
@ -290,28 +331,7 @@ class ApplicationMenu extends BaseMenu {
</div>
</div>
<div className={styles.row}>
<div className={styles.col} aria-hidden="true">
<div className={styles.formElement}>
<label className={styles.label}>
{intl.formatMessage(intlMessages.audioFilterLabel)}
</label>
</div>
</div>
<div className={styles.col}>
<div className={cx(styles.formElement, styles.pullContentRight)}>
{displaySettingsStatus(ApplicationMenu.isAudioFilterEnabled(settings.microphoneConstraints))}
<Toggle
icons={false}
defaultChecked={this.state.audioFilterEnabled}
onChange={() => this.handleAudioFilterChange()}
ariaLabel={intl.formatMessage(intlMessages.audioFilterLabel)}
showToggleLabel={showToggleLabel}
/>
</div>
</div>
</div>
{this.renderAudioFilters()}
{this.renderPaginationToggle()}
<div className={styles.row}>

7
bigbluebutton-html5/private/config/settings.yml
View File

@ -68,6 +68,13 @@ public:
# https://github.com/bigbluebutton/bigbluebutton/pull/10826
customHeartbeat: false
showAllAvailableLocales: true
# Show "Audio Filters for Microphone" option in settings menu.
# When set to true, users are able to enable/disable microphone constraints,
# otherwise default values for 'microphoneConstraints' option
# are used.
# For more info, see 'microphoneConstraints' option in this config.
# If not set, default value is true.
showAudioFilters: true
defaultSettings:
application:
animations: true