BigBlueButton/bigbluebutton-Github
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

adds fixes adding timestamp to metrics filename and to the use of effectiveParams object

Browse Source
This commit is contained in:
Mohamed Amine Ben Salah 2020-02-18 15:45:46 -03:00
parent 2ff8ad3b44
commit c4a658b25f
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
bigbluebutton-html5/tests/puppeteer/core/page.js
View File

@ -21,21 +21,21 @@ class Page {
// Join BigBlueButton meeting
async init(args, meetingId, newParams) {
const effectiveParams = newParams || params;
this.effectiveParams = newParams || params;
this.browser = await puppeteer.launch(args);
this.page = await this.browser.newPage({ context: `bbb-${effectiveParams.fullName}` });
this.page = await this.browser.newPage({ context: `bbb-${this.effectiveParams.fullName}` });
await this.setDownloadBehavior(`${this.parentDir}/downloads`);
this.meetingId = await helper.createMeeting(params, meetingId);
const joinURL = helper.getJoinURL(this.meetingId, effectiveParams, true);
const joinURL = helper.getJoinURL(this.meetingId, this.effectiveParams, true);
await this.page.goto(joinURL);
await this.waitForSelector(e.audioDialog);
await this.click(e.closeAudio, true);
const checkForGetMetrics = async () => {
if (process.env.BBB_COLLECT_METRICS === 'true') {
await this.getMetrics(effectiveParams.fullName);
await this.getMetrics();
}
};
await checkForGetMetrics();
@ -150,7 +150,7 @@ class Page {
metricsObj[`metricObj-${this.effectiveParams.fullName}`] = metric;
const createFile = () => {
try {
fs.appendFileSync((`${dir}/metrics-${this.effectiveParams.fullName}-${currentTimestamp}.json`), `${JSON.stringify(metricsObj)}\n`);
fs.appendFileSync(`${dir}/metrics-${this.effectiveParams.fullName}-${currentTimestamp}.json`, `${JSON.stringify(metricsObj)}\n`);
} catch (error) {
console.log(error);
}