From 3f383a8b402f303d0967ceb79c83a63206c5e316 Mon Sep 17 00:00:00 2001
From: Pedro Beschorner Marin <pedrobmarin@gmail.com>
Date: Fri, 18 Aug 2017 16:06:02 +0000
Subject: [PATCH 1/4] Making role bindable so binding utils will be triggered
 when it changes

---
 .../src/org/bigbluebutton/core/model/users/User2x.as            | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bigbluebutton-client/src/org/bigbluebutton/core/model/users/User2x.as b/bigbluebutton-client/src/org/bigbluebutton/core/model/users/User2x.as
index 48a6954c69..8ec22f03af 100755
--- a/bigbluebutton-client/src/org/bigbluebutton/core/model/users/User2x.as
+++ b/bigbluebutton-client/src/org/bigbluebutton/core/model/users/User2x.as
@@ -6,7 +6,7 @@ package org.bigbluebutton.core.model.users
     public var intId: String;
     public var extId: String;
     public var name: String;
-    public var role: String;
+    [Bindable] public var role: String;
     public var guest: Boolean;
     public var authed: Boolean;
     public var waitingForAcceptance: Boolean;

From da32a11771c256b178fc71f7f88f954e14b87136 Mon Sep 17 00:00:00 2001
From: Pedro Beschorner Marin <pedrobmarin@gmail.com>
Date: Fri, 18 Aug 2017 19:43:35 +0000
Subject: [PATCH 2/4] Moving the close button event listener instantiation to
 the end of the additional shared note window creation

---
 .../modules/sharednotes/views/AdditionalSharedNotesWindow.as   | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/bigbluebutton-client/src/org/bigbluebutton/modules/sharednotes/views/AdditionalSharedNotesWindow.as b/bigbluebutton-client/src/org/bigbluebutton/modules/sharednotes/views/AdditionalSharedNotesWindow.as
index 9a67921594..76ed4cc897 100644
--- a/bigbluebutton-client/src/org/bigbluebutton/modules/sharednotes/views/AdditionalSharedNotesWindow.as
+++ b/bigbluebutton-client/src/org/bigbluebutton/modules/sharednotes/views/AdditionalSharedNotesWindow.as
@@ -28,8 +28,6 @@ package org.bigbluebutton.modules.sharednotes.views
 			showCloseButton = UsersUtil.amIModerator();
 			width = 240;
 			height = 240;
-
-			closeBtn.addEventListener(MouseEvent.CLICK, onCloseBtnClick);
 		}
 
 		public function get windowName():String {
@@ -46,6 +44,7 @@ package org.bigbluebutton.modules.sharednotes.views
 			LOGGER.debug("AdditionalSharedNotesWindow: [2] in-constructor additional notes " + noteId);
 
 			btnNew.visible = btnNew.includeInLayout = false;
+			closeBtn.addEventListener(MouseEvent.CLICK, onCloseBtnClick);
 		}
 
 		private function onCloseBtnClick(e:MouseEvent):void {

From 06d937958fb802a5e0b6a018aca9aa8789aeb717 Mon Sep 17 00:00:00 2001
From: Pedro Beschorner Marin <pedrobmarin@gmail.com>
Date: Mon, 21 Aug 2017 18:23:33 +0000
Subject: [PATCH 3/4] Setting maximum size to shared notes and pastes

---
 .../locale/en_US/bbbResources.properties        |  1 +
 .../resources/config.xml.template               |  2 ++
 .../modules/sharednotes/SharedNotesOptions.as   |  6 ++++++
 .../sharednotes/views/SharedNotesWindow.mxml    | 10 ++++++++++
 .../components/SharedNotesRichTextEditor.mxml   | 17 +++++++++++++++++
 5 files changed, 36 insertions(+)

diff --git a/bigbluebutton-client/locale/en_US/bbbResources.properties b/bigbluebutton-client/locale/en_US/bbbResources.properties
index d79383a91f..461abab44c 100755
--- a/bigbluebutton-client/locale/en_US/bbbResources.properties
+++ b/bigbluebutton-client/locale/en_US/bbbResources.properties
@@ -530,6 +530,7 @@ bbb.sharedNotes.redo.toolTip = Redo modification
 bbb.sharedNotes.toolbar.toolTip = Text formatting toolbar
 bbb.sharedNotes.additionalNotes.closeWarning.title = Closing shared notes
 bbb.sharedNotes.additionalNotes.closeWarning.message = This action will destroy the notes on this window for everyone, and there's no way to undo. Are you sure you want to close these notes?
+bbb.sharedNotes.pastewarning.title = Shared Notes Paste Warning
 bbb.settings.deskshare.instructions = Choose Allow on the prompt that pops up to check that desktop sharing is working properly for you
 bbb.settings.deskshare.start = Check Desktop Sharing
 bbb.settings.voice.volume = Microphone Activity
diff --git a/bigbluebutton-client/resources/config.xml.template b/bigbluebutton-client/resources/config.xml.template
index 3bc2b70838..5fc76d2fd7 100755
--- a/bigbluebutton-client/resources/config.xml.template
+++ b/bigbluebutton-client/resources/config.xml.template
@@ -130,6 +130,8 @@
 			toolbarVisibleByDefault="false"
 			showToolbarButton="true"
 			fontSize="12"
+			maxPasteLength="1024"
+			maxNoteLenght="5120"
 		/>
 
 <!--
diff --git a/bigbluebutton-client/src/org/bigbluebutton/modules/sharednotes/SharedNotesOptions.as b/bigbluebutton-client/src/org/bigbluebutton/modules/sharednotes/SharedNotesOptions.as
index 555450988f..436704f03a 100755
--- a/bigbluebutton-client/src/org/bigbluebutton/modules/sharednotes/SharedNotesOptions.as
+++ b/bigbluebutton-client/src/org/bigbluebutton/modules/sharednotes/SharedNotesOptions.as
@@ -18,6 +18,12 @@ package org.bigbluebutton.modules.sharednotes {
 		[Bindable]
 		public var fontSize:int = 10;
 
+		[Bindable]
+		public var maxPasteLength:int = 1024;
+
+		[Bindable]
+		public var maxNoteLength:int = 10240;
+
 		public function SharedNotesOptions() {
 			name = "SharedNotesModule";
 		}
diff --git a/bigbluebutton-client/src/org/bigbluebutton/modules/sharednotes/views/SharedNotesWindow.mxml b/bigbluebutton-client/src/org/bigbluebutton/modules/sharednotes/views/SharedNotesWindow.mxml
index 3207044bdb..e164231f40 100644
--- a/bigbluebutton-client/src/org/bigbluebutton/modules/sharednotes/views/SharedNotesWindow.mxml
+++ b/bigbluebutton-client/src/org/bigbluebutton/modules/sharednotes/views/SharedNotesWindow.mxml
@@ -145,6 +145,8 @@
 				richTextEditor.bulletButton.visible = false;
 				richTextEditor.bulletButton.height = 0;
 				richTextEditor.bulletButton.width = 0;
+
+				richTextEditor.textArea.maxChars = options.maxNoteLength;
 			}
 
 			private function updateRoleDependentProperties(role:String):void {
@@ -422,6 +424,10 @@
 				return true;
 			}
 
+			public function throwPasteWarning(pasteLength:int):void {
+				Alert.show(ResourceUtil.getInstance().getString("bbb.caption.transcript.pastewarning.text", [options.maxPasteLength, pasteLength]), ResourceUtil.getInstance().getString("bbb.sharedNotes.pastewarning.title"), Alert.OK);
+			}
+
 			protected function btnToolbar_clickHandler(event:MouseEvent):void {
 				richTextEditor.showControlBar = !richTextEditor.showControlBar;
 			}
@@ -491,6 +497,10 @@
 						enabled="false" visible="true"/>
 			</mx:HBox>
 			<mx:HBox width="100%" horizontalAlign="right" paddingTop="0">
+				<mx:Label id="charRemain"
+						includeInLayout="true"
+						visible="{(options.maxNoteLength - richTextEditor.text.length) &lt; (options.maxNoteLength / 8)}"
+						text="{options.maxNoteLength - richTextEditor.text.length}"/>
 				<mx:Button id="btnNew"
 						styleName="sharedNotesNewButtonStyle"
 						width="26"
diff --git a/bigbluebutton-client/src/org/bigbluebutton/modules/sharednotes/views/components/SharedNotesRichTextEditor.mxml b/bigbluebutton-client/src/org/bigbluebutton/modules/sharednotes/views/components/SharedNotesRichTextEditor.mxml
index 9c64332040..ee8dd54fc0 100644
--- a/bigbluebutton-client/src/org/bigbluebutton/modules/sharednotes/views/components/SharedNotesRichTextEditor.mxml
+++ b/bigbluebutton-client/src/org/bigbluebutton/modules/sharednotes/views/components/SharedNotesRichTextEditor.mxml
@@ -991,6 +991,17 @@
     private var shiftPressed:Boolean = false;
     private var ctrlPressed:Boolean = false;
     private var preventTextInput:Boolean = false;
+    private var _maxPasteLength:int = 1024;
+
+    public function set maxPasteLength(value:int):void
+    {
+        _maxPasteLength = value;
+    }
+
+    public function get maxPasteLength():int
+    {
+        return _maxPasteLength;
+    }
 
     public function restoreVerticalScroll(oldVerticalScroll:Number):void
     {
@@ -1216,6 +1227,12 @@
     {
         if (e.text.length > 0) refreshSelection = true;
 
+        if (e.text.length > maxPasteLength)
+        {
+            e.preventDefault();
+            parentDocument.throwPasteWarning(e.text.length);
+        }
+
         if (preventTextInput) e.preventDefault();
     }
 

From 2cc03d5d540fb19680853028d0a16f683263251f Mon Sep 17 00:00:00 2001
From: Pedro Beschorner Marin <pedrobmarin@gmail.com>
Date: Mon, 21 Aug 2017 19:50:32 +0000
Subject: [PATCH 4/4] Avoiding bad resync in shared notes

---
 .../modules/sharednotes/views/SharedNotesWindow.mxml           | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/bigbluebutton-client/src/org/bigbluebutton/modules/sharednotes/views/SharedNotesWindow.mxml b/bigbluebutton-client/src/org/bigbluebutton/modules/sharednotes/views/SharedNotesWindow.mxml
index e164231f40..645fedae10 100644
--- a/bigbluebutton-client/src/org/bigbluebutton/modules/sharednotes/views/SharedNotesWindow.mxml
+++ b/bigbluebutton-client/src/org/bigbluebutton/modules/sharednotes/views/SharedNotesWindow.mxml
@@ -209,10 +209,11 @@
 							_document = result;
 //							LOGGER.debug("SharedNotes: patching local with server modifications");
 							richTextEditor.patch(e.patch);
+							/* This code is forcing resync and causing more problems then resolving
 							if (possiblePatchError()) {
 								syncNote();
 								return;
-							}
+							}*/
 						}
 						_lastPatch = e.patchId;
 						updateUndoRedoButtons(e.undo, e.redo);