Merge pull request #7500 from capilkey/fix-html5-logout

Fix HTML5 logout
This commit is contained in:
Chad Pilkey 2019-05-24 18:59:19 -04:00 committed by GitHub
commit b8e4445eb8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 3 deletions

View File

@ -182,7 +182,10 @@ class Base extends Component {
}
if (codeError && !meetingHasEnded) {
logger.error({ logCode: 'startup_client_usercouldnotlogin_error' }, `User could not log in HTML5, hit ${codeError}`);
// 680 is set for the codeError when the user requests a logout
if (codeError !== '680') {
logger.error({ logCode: 'startup_client_usercouldnotlogin_error' }, `User could not log in HTML5, hit ${codeError}`);
}
return (<ErrorScreen code={codeError} />);
}
// this.props.annotationsHandler.stop();

View File

@ -127,7 +127,9 @@ class App extends Component {
componentWillUnmount() {
window.removeEventListener('resize', this.handleWindowResize, false);
navigator.connection.addEventListener('change', this.handleNetworkConnection, false);
if (navigator.connection) {
navigator.connection.addEventListener('change', this.handleNetworkConnection, false);
}
}
handleWindowResize() {

View File

@ -166,7 +166,8 @@ class SettingsDropdown extends PureComponent {
leaveSession() {
document.dispatchEvent(new Event('exitVideo'));
const LOGOUT_CODE = '403';
// Set the logout code to 680 because it's not a real code and can be matched on the other side
const LOGOUT_CODE = '680';
makeCall('userLeftMeeting');
// we don't check askForFeedbackOnLogout here,
// it is checked in meeting-ended component