BigBlueButton/bigbluebutton-Github
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(voice): keep voice activity hooks pure by skipping state update when applicable

Browse Source
This commit is contained in:
João Victor 2024-08-15 09:13:12 -03:00
parent c6e8464693
commit b2adf9ad15
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
bigbluebutton-html5/imports/ui/core/hooks/useWhoIsTalking.ts
View File

@ -1,4 +1,5 @@
import { useEffect } from 'react';
import { isEqual } from 'radash';
import { makeVar, useReactiveVar } from '@apollo/client';
import { VoiceActivityResponse } from '/imports/ui/core/graphql/queries/whoIsTalking';
@ -34,6 +35,10 @@ const createUseWhoIsTalking = () => {
newTalkingUsers[userId] = talking;
});
if (isEqual(getWhoIsTalking(), newTalkingUsers)) {
return;
}
setWhoIsTalkingState(newTalkingUsers);
};

5
bigbluebutton-html5/imports/ui/core/hooks/useWhoIsUnmuted.ts
View File

@ -1,4 +1,5 @@
import { useEffect } from 'react';
import { isEqual } from 'radash';
import { makeVar, useReactiveVar } from '@apollo/client';
import { VoiceActivityResponse } from '/imports/ui/core/graphql/queries/whoIsTalking';
@ -34,6 +35,10 @@ const createUseWhoIsUnmuted = () => {
newUnmutedUsers[userId] = true;
});
if (isEqual(getWhoIsUnmuted(), newUnmutedUsers)) {
return;
}
setWhoIsUnmutedState(newUnmutedUsers);
};