BigBlueButton/bigbluebutton-Github
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(bbb-webrtc-sfu): add ALLOW_CONFIG_MUTATIONS to service

Browse Source 
After node-config was bumped to 3.3.9 (from 3.3.6), it started throwing errors if
configurations are mutated without the ALLOW_CONFIG_MUTATIONS env var set.
We mutate some configs directly, but I every time I added one of those I made sure that
they are always deep cloned.

However, we hit an issue with kurento-client mutating a config input, which is an indirect mutation.
So, to prevent further surprises I'm allowing mutations on production while prohibiting them in dev
envs until I'm 100% sure nothing, direct on indirect, improperly mutates configuration values.
This commit is contained in:
Paulo Lanzarin 2023-03-13 12:20:00 -03:00 committed by GitHub
parent 3f42ed89f7
commit 9ef74eeb53
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
build/packages-template/bbb-webrtc-sfu/bbb-webrtc-sfu.service
View File

@ -13,6 +13,7 @@ User=bigbluebutton
Group=bigbluebutton
Environment=NODE_ENV=production
Environment=NODE_CONFIG_DIR=/etc/bigbluebutton/bbb-webrtc-sfu/:/usr/local/bigbluebutton/bbb-webrtc-sfu/config/
Environment=ALLOW_CONFIG_MUTATIONS=true
CPUSchedulingPolicy=fifo
Nice=19