From 9ef74eeb53ae2f26c957b1e43d64c00904fcaedd Mon Sep 17 00:00:00 2001 From: Paulo Lanzarin <4529051+prlanzarin@users.noreply.github.com> Date: Mon, 13 Mar 2023 12:20:00 -0300 Subject: [PATCH] fix(bbb-webrtc-sfu): add ALLOW_CONFIG_MUTATIONS to service After node-config was bumped to 3.3.9 (from 3.3.6), it started throwing errors if configurations are mutated without the ALLOW_CONFIG_MUTATIONS env var set. We mutate some configs directly, but I every time I added one of those I made sure that they are always deep cloned. However, we hit an issue with kurento-client mutating a config input, which is an indirect mutation. So, to prevent further surprises I'm allowing mutations on production while prohibiting them in dev envs until I'm 100% sure nothing, direct on indirect, improperly mutates configuration values. --- build/packages-template/bbb-webrtc-sfu/bbb-webrtc-sfu.service | 1 + 1 file changed, 1 insertion(+) diff --git a/build/packages-template/bbb-webrtc-sfu/bbb-webrtc-sfu.service b/build/packages-template/bbb-webrtc-sfu/bbb-webrtc-sfu.service index 9f73b71764..159573311d 100644 --- a/build/packages-template/bbb-webrtc-sfu/bbb-webrtc-sfu.service +++ b/build/packages-template/bbb-webrtc-sfu/bbb-webrtc-sfu.service @@ -13,6 +13,7 @@ User=bigbluebutton Group=bigbluebutton Environment=NODE_ENV=production Environment=NODE_CONFIG_DIR=/etc/bigbluebutton/bbb-webrtc-sfu/:/usr/local/bigbluebutton/bbb-webrtc-sfu/config/ +Environment=ALLOW_CONFIG_MUTATIONS=true CPUSchedulingPolicy=fifo Nice=19