BigBlueButton/bigbluebutton-Github
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #20009 from prlanzarin/u27/fix/onconnectionstatechange-crash-rc

Browse Source 
[2.7] fix(bbb-html5): crash when stopping WebRTC peers
This commit is contained in:
Anton Georgiev 2024-04-12 15:15:03 -04:00 committed by GitHub
commit 711487c2c9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
bigbluebutton-html5/imports/ui/services/bbb-webrtc-sfu/sfu-base-broker.js
View File

@ -283,7 +283,9 @@ class BaseBroker {
} }
if (connectionState === 'failed' || connectionState === 'closed') { if (connectionState === 'failed' || connectionState === 'closed') {
this.webRtcPeer.peerConnection.onconnectionstatechange = null; if (this.webRtcPeer?.peerConnection) {
this.webRtcPeer.peerConnection.onconnectionstatechange = null;
}
// 1307: "ICE_STATE_FAILED", // 1307: "ICE_STATE_FAILED",
const error = BaseBroker.assembleError(1307); const error = BaseBroker.assembleError(1307);
this.onerror(error); this.onerror(error);
@ -343,7 +345,7 @@ class BaseBroker {
this.onerror = function(){}; this.onerror = function(){};
window.removeEventListener('beforeunload', this.onbeforeunload); window.removeEventListener('beforeunload', this.onbeforeunload);
if (this.webRtcPeer) { if (this.webRtcPeer?.peerConnection) {
this.webRtcPeer.peerConnection.onconnectionstatechange = null; this.webRtcPeer.peerConnection.onconnectionstatechange = null;
} }