Merge pull request #13089 from ramonlsouza/fix-lgtm-alerts

remove useless conditionals - LGTM alerts

bigbluebutton-html5/imports/ui/components/chat/alert/component.jsx

@@ -76,7 +76,7 @@ const ChatAlert = (props) => {
         : unreadObject.filter((chat) => chat.chatId !== idChatOpen)
           .reduce((a, b) => a + b.unreadCounter, 0);
 
-      if (audioAlertEnabled && unreadCount > unreadMessagesCount) {
+      if (unreadCount > unreadMessagesCount) {
         AudioService.playAlertSound(`${Meteor.settings.public.app.cdn
           + Meteor.settings.public.app.basename
           + Meteor.settings.public.app.instanceId}`

bigbluebutton-html5/imports/ui/components/nav-bar/component.jsx

@@ -163,6 +163,7 @@ class NavBar extends Component {
               circle
               hideLabel
               data-test={hasNotification ? 'hasUnreadMessages' : null}
+              label={intl.formatMessage(intlMessages.toggleUserListLabel)}
               tooltipLabel={intl.formatMessage(intlMessages.toggleUserListLabel)}
               aria-label={ariaLabel}
               icon="user"

bigbluebutton-html5/imports/ui/components/poll/component.jsx

@@ -707,7 +707,7 @@ class Poll extends Component {
 
     if (!currentSlide) return this.renderNoSlidePanel();
 
-    if (isPolling || (!isPolling && currentPoll)) {
+    if (isPolling || currentPoll) {
       return this.renderActivePollOptions();
     }
 

bigbluebutton-html5/imports/ui/components/user-list/user-list-content/user-participants/user-list-item/user-name/component.jsx

@@ -78,10 +78,6 @@ const UserName = (props) => {
 
   const userNameSub = [];
 
-  if (compact) {
-    return null;
-  }
-
   if (user.isSharingWebcam && LABEL.sharingWebcam) {
     userNameSub.push(
       <span key={_.uniqueId('video-')}>