BigBlueButton/bigbluebutton-Github
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #18351 from Scroody/fix-warnings

Browse Source 
Fix: Warnings when creating a new meeting
This commit is contained in:
Ramón Souza 2023-07-20 17:00:15 -03:00 committed by GitHub
commit 5bb012a6a9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
18 changed files with 26 additions and 47 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
bigbluebutton-html5/imports/ui/components/actions-bar/actions-dropdown/component.jsx
View File

@ -403,7 +403,7 @@ class ActionsDropdown extends PureComponent {
<BBBMenu
customStyles={!isMobile ? customStyles : null}
accessKey={OPEN_ACTIONS_AK}
trigger={
trigger={(
<Styled.HideDropdownButton
open={isDropdownOpen}
hideLabel
@ -416,7 +416,7 @@ class ActionsDropdown extends PureComponent {
circle
onClick={() => null}
/>
}
)}
actions={children}
opts={{
id: 'actions-dropdown-menu',

2
bigbluebutton-html5/imports/ui/components/actions-bar/reactions-button/component.jsx
View File

@ -82,7 +82,7 @@ const ReactionsButton = (props) => {
keepMounted: true,
transitionDuration: 0,
elevation: 3,
getContentAnchorEl: null,
getcontentanchorel: null,
anchorOrigin: { vertical: 'top', horizontal: 'center' },
transformOrigin: { vertical: 'bottom', horizontal: 'center' },
}}

15
bigbluebutton-html5/imports/ui/components/app/container.jsx
View File

@ -92,14 +92,16 @@ const AppContainer = (props) => {
const { focusedId } = cameraDock;
if(
layoutContextDispatch
&& (typeof meetingLayout != "undefined")
&& (layoutType.current != meetingLayout)
useEffect(() => {
if (
layoutContextDispatch
&& (typeof meetingLayout !== 'undefined')
&& (layoutType.current !== meetingLayout)
) {
layoutType.current = meetingLayout;
MediaService.setPresentationIsOpen(layoutContextDispatch, true);
}
}
}, [meetingLayout, layoutContextDispatch, layoutType]);
const horizontalPosition = cameraDock.position === 'contentLeft' || cameraDock.position === 'contentRight';
// this is not exactly right yet
@ -140,7 +142,8 @@ const AppContainer = (props) => {
};
useEffect(() => {
MediaService.buildLayoutWhenPresentationAreaIsDisabled(layoutContextDispatch)});
MediaService.buildLayoutWhenPresentationAreaIsDisabled(layoutContextDispatch)
});
return currentUserId
? (

17
bigbluebutton-html5/imports/ui/components/common/menu/component.jsx
View File

@ -100,7 +100,7 @@ class BBBMenu extends React.Component {
const { actions, selectedEmoji, intl } = this.props;
return actions?.map(a => {
const { dataTest, label, onClick, key, disabled, accessKey, description, selected } = a;
const { dataTest, label, onClick, key, disabled, description, selected } = a;
const emojiSelected = key?.toLowerCase()?.includes(selectedEmoji?.toLowerCase());
let customStyles = {
@ -143,7 +143,7 @@ class BBBMenu extends React.Component {
</Styled.BBBMenuItem>,
a.divider && <Divider disabled />
];
});
}) ?? [];
}
render() {
@ -247,18 +247,7 @@ BBBMenu.propTypes = {
trigger: PropTypes.element.isRequired,
actions: PropTypes.arrayOf(PropTypes.shape({
key: PropTypes.string.isRequired,
label: PropTypes.string.isRequired,
onClick: PropTypes.func,
icon: PropTypes.string,
iconRight: PropTypes.string,
disabled: PropTypes.bool,
divider: PropTypes.bool,
dividerTop: PropTypes.bool,
accessKey: PropTypes.string,
dataTest: PropTypes.string,
})).isRequired,
actions: PropTypes.array.isRequired,
onCloseCallback: PropTypes.func,
dataTest: PropTypes.string,

4
bigbluebutton-html5/imports/ui/components/common/modal/base/component.jsx
View File

@ -19,7 +19,7 @@ const BaseModal = (props) => {
}, []);
useEffect(() => {
// Only add event listener if name is specified
if (!modalName) return;
if (!modalName) return () => null;
const closeEventName = `CLOSE_MODAL_${modalName.toUpperCase()}`;
@ -28,7 +28,7 @@ const BaseModal = (props) => {
// Remove listener on unmount
return () => {
document.removeEventListener(closeEventName, closeEventHandler);
document.removeEventListener(closeEventName, closeEventHandler);
};
}, []);
const priorityValue = priority || 'low';

2
bigbluebutton-html5/imports/ui/components/components-data/chat-context/adapter.jsx
View File

@ -114,7 +114,7 @@ const Adapter = () => {
}, [usingUsersContext]);
useEffect(() => {
if (!Meteor.status().connected) return;
if (!Meteor.status().connected) return () => null;
setSync(false);
dispatch({
type: ACTIONS.CLEAR_ALL,

1
bigbluebutton-html5/imports/ui/components/components-data/group-chat-context/adapter.jsx
View File

@ -20,7 +20,6 @@ const Adapter = () => {
},
});
}, []);
return null;
};
export default Adapter;

2
bigbluebutton-html5/imports/ui/components/layout/layout-manager/customLayout.jsx
View File

@ -64,7 +64,7 @@ const CustomLayout = (props) => {
}, []);
useEffect(() => {
if (deviceType === null) return;
if (deviceType === null) return () => null;
if (deviceType !== prevDeviceType) {
// reset layout if deviceType changed

2
bigbluebutton-html5/imports/ui/components/layout/layout-manager/presentationFocusLayout.jsx
View File

@ -64,7 +64,7 @@ const PresentationFocusLayout = (props) => {
}, []);
useEffect(() => {
if (deviceType === null) return;
if (deviceType === null) return () => null;
if (deviceType !== prevDeviceType) {
// reset layout if deviceType changed

2
bigbluebutton-html5/imports/ui/components/layout/layout-manager/smartLayout.jsx
View File

@ -59,7 +59,7 @@ const SmartLayout = (props) => {
}, []);
useEffect(() => {
if (deviceType === null) return;
if (deviceType === null) return () => null;
if (deviceType !== prevDeviceType) {
// reset layout if deviceType changed

2
bigbluebutton-html5/imports/ui/components/layout/layout-manager/videoFocusLayout.jsx
View File

@ -67,7 +67,7 @@ const VideoFocusLayout = (props) => {
}, []);
useEffect(() => {
if (deviceType === null) return;
if (deviceType === null) return () => null;
if (deviceType !== prevDeviceType) {
// reset layout if deviceType changed

2
bigbluebutton-html5/imports/ui/components/presentation/presentation-uploader/presentation-download-dropdown/component.jsx
View File

@ -139,7 +139,7 @@ class PresentationDownloadDropdown extends PureComponent {
keepMounted: true,
transitionDuration: 0,
elevation: 2,
getContentAnchorEl: null,
getcontentanchorel: null,
fullwidth: 'true',
anchorOrigin: { vertical: 'bottom', horizontal: isRTL ? 'right' : 'left' },
transformOrigin: { vertical: 'top', horizontal: isRTL ? 'right' : 'left' },

3
bigbluebutton-html5/imports/ui/components/sidebar-content/component.jsx
View File

@ -65,9 +65,6 @@ const SidebarContent = (props) => {
}
}, [width, height]);
useEffect(() => {
}, [resizeStartWidth, resizeStartHeight]);
const setSidebarContentSize = (dWidth, dHeight) => {
const newWidth = resizeStartWidth + dWidth;
const newHeight = resizeStartHeight + dHeight;

3
bigbluebutton-html5/imports/ui/components/sidebar-navigation/component.jsx
View File

@ -46,9 +46,6 @@ const SidebarNavigation = (props) => {
if (!isResizing) setResizableWidth(width);
}, [width]);
useEffect(() => {
}, [resizeStartWidth]);
const setSidebarNavWidth = (dWidth) => {
const newWidth = resizeStartWidth + dWidth;

2
bigbluebutton-html5/imports/ui/components/subscriptions/component.jsx
View File

@ -13,8 +13,6 @@ import SubscriptionRegistry, { subscriptionReactivity } from '../../services/sub
import { isChatEnabled } from '/imports/ui/services/features';
const CHAT_CONFIG = Meteor.settings.public.chat;
const PUBLIC_GROUP_CHAT_ID = CHAT_CONFIG.public_group_id;
const PUBLIC_CHAT_TYPE = CHAT_CONFIG.type_public;
const TYPING_INDICATOR_ENABLED = CHAT_CONFIG.typingIndicator.enabled;
const SUBSCRIPTIONS = [
'users', 'meetings', 'polls', 'presentations', 'slides', 'slide-positions', 'captions',

7
bigbluebutton-html5/imports/ui/components/timer/indicator/component.jsx
View File

@ -12,13 +12,10 @@ const trackName = Meteor.settings.public.timer.music;
const TAB_TIMER_INDICATOR = Meteor.settings.public.timer.tabIndicator;
const propTypes = {
intl: PropTypes.shape({
formatMessage: PropTypes.func.isRequired,
}).isRequired,
timer: PropTypes.shape({
stopwatch: PropTypes.bool,
running: PropTypes.bool,
time: PropTypes.string,
time: PropTypes.number,
accumulated: PropTypes.number,
timestamp: PropTypes.number,
}).isRequired,
@ -28,7 +25,7 @@ const propTypes = {
sidebarContentIsOpen: PropTypes.bool.isRequired,
timeOffset: PropTypes.number.isRequired,
isModerator: PropTypes.bool.isRequired,
currentTrack: PropTypes.string.isRequired,
currentTrack: PropTypes.bool.isRequired,
};
class Indicator extends Component {

2
bigbluebutton-html5/imports/ui/components/utils/hooks/index.js
View File

@ -12,7 +12,7 @@ export const usePreviousValue = (value) => {
ref.current = value;
});
return ref.current;
}
};
export default {
usePreviousValue,

1
bigbluebutton-html5/imports/ui/components/video-provider/video-button/component.jsx
View File

@ -14,7 +14,6 @@ import Settings from '/imports/ui/services/settings';
const ENABLE_WEBCAM_SELECTOR_BUTTON = Meteor.settings.public.app.enableWebcamSelectorButton;
const ENABLE_CAMERA_BRIGHTNESS = Meteor.settings.public.app.enableCameraBrightness;
const isSelfViewDisabled = Settings.application.selfViewDisable;
const intlMessages = defineMessages({
videoSettings: {