From 50670365c5b2aa12bcc2d963fc73c0691173fa6b Mon Sep 17 00:00:00 2001 From: Chad Pilkey Date: Thu, 21 Feb 2019 12:53:39 -0800 Subject: [PATCH] dont log ice closed if user requested hangup --- .../imports/api/audio/client/bridge/sip.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/bigbluebutton-html5/imports/api/audio/client/bridge/sip.js b/bigbluebutton-html5/imports/api/audio/client/bridge/sip.js index 4c2595a53e..339b6b5750 100755 --- a/bigbluebutton-html5/imports/api/audio/client/bridge/sip.js +++ b/bigbluebutton-html5/imports/api/audio/client/bridge/sip.js @@ -71,9 +71,9 @@ export default class SIPBridge extends BaseAudioBridge { userId, 'bbbID', isListenOnly ? `LISTENONLY-${name}` : name, - ].join('-'); + ].join('-').replace(/"/g, "'"); - this.user.callerIdName = callerIdName.replace(/"/g, "'"); + this.user.callerIdName = callerIdName; this.callOptions = options; return fetchStunTurnServers(sessionToken) @@ -357,7 +357,9 @@ export default class SIPBridge extends BaseAudioBridge { const handleIceConnectionTerminated = (peer) => { ['iceConnectionClosed'].forEach(e => mediaHandler.off(e, handleIceConnectionTerminated)); - logger.error({ logCode: 'sipjs_ice_closed' }, 'ICE connection closed'); + if (!this.userRequestedHangup) { + logger.error({ logCode: 'sipjs_ice_closed' }, 'ICE connection closed'); + } /* this.callback({ status: this.baseCallStates.failed,