BigBlueButton/bigbluebutton-Github
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(audio): minimize redundant audio exit toasts

Browse Source 
Audio exit toasts are fired in some redundant situations, e.g.: when the
error help screen is toast.

Change the logic a bit so that it's only fired when the audio help modal
won't be shown, i.e.: when audio had succesfully connected.
This commit is contained in:
prlanzarin 2024-04-11 18:30:55 -03:00
parent fcbfcb1bbc
commit 4e93a4de72
1 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
bigbluebutton-html5/imports/ui/services/audio-manager/index.js
View File

@ -475,6 +475,7 @@ class AudioManager {
} }
forceExitAudio() { forceExitAudio() {
this.notifyAudioExit();
this.isConnected = false; this.isConnected = false;
this.isConnecting = false; this.isConnecting = false;
this.isHangingUp = false; this.isHangingUp = false;
@ -604,7 +605,21 @@ class AudioManager {
this.isConnecting = true; this.isConnecting = true;
} }
// Must be called before the call is actually torn down (this.isConnected = true)
notifyAudioExit() {
try {
if (!this.error && (this.isConnected && !this.isEchoTest)) {
this.notify(
this.intl.formatMessage(this.messages.info.LEFT_AUDIO),
false,
'no_audio',
);
}
} catch {}
}
onAudioExit() { onAudioExit() {
this.notifyAudioExit();
this.isConnected = false; this.isConnected = false;
this.isConnecting = false; this.isConnecting = false;
this.isHangingUp = false; this.isHangingUp = false;
@ -616,13 +631,6 @@ class AudioManager {
this.inputStream = null; this.inputStream = null;
} }
if (!this.error && !this.isEchoTest) {
this.notify(
this.intl.formatMessage(this.messages.info.LEFT_AUDIO),
false,
'no_audio'
);
}
if (!this.isEchoTest) { if (!this.isEchoTest) {
this.playHangUpSound(); this.playHangUpSound();
} }