BigBlueButton/bigbluebutton-Github
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: remove spurious getUserMedia in ErrorScreen

Browse Source 
There's a very odd getUserMedia call tucked into the base ErrorScreen.
There's no rationale in either the commit or PR that added them, but the
intention seems to be stopping audio on client crash.
Using getUserMedia like that will have no effect other than an odd
permission prompt on iframe-based environments or a webcam activation
flash after the client crashes.

Remove ErrorScreen's getUserMedia call as well as the HTMLMedia pause
call - both should be handled gracefully by AudioManager's forceExitAudio
triggered by the StopAudioTracks event (also ErrorScreen). If there's an
edge case where it isn't properly stopped, we'll have to tackle it
there.
This commit is contained in:
prlanzarin 2024-08-09 19:24:33 +00:00
parent 6a3a3bdf1d
commit 4dcc77968b
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
bigbluebutton-html5/imports/ui/components/error-screen/component.jsx
View File

@ -93,11 +93,6 @@ class ErrorScreen extends PureComponent {
componentDidMount() {
const { code, callback, endedReason } = this.props;
// stop audio
document.querySelector('audio').pause();
navigator
.mediaDevices
.getUserMedia({ audio: true, video: true })
.then((m) => m.getTracks().forEach((t) => t.stop()));
window.dispatchEvent(new Event('StopAudioTracks'));
callback(endedReason, () => {});
console.error({ logCode: 'startup_client_usercouldnotlogin_error' }, `User could not log in HTML5, hit ${code}`);