Merge pull request #7372 from KDSBrowne/_summit-improve-modal-title-announced

Improve labels announced for modal titles
This commit is contained in:
Anton Georgiev 2019-05-08 10:18:26 -04:00 committed by GitHub
commit 49b571dcc0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 14 additions and 1 deletions

View File

@ -96,6 +96,10 @@ const intlMessages = defineMessages({
id: 'app.audioModal.connectingEchoTest',
description: 'Message for echo test connecting',
},
ariaModalTitle: {
id: 'app.audioModal.ariaTitle',
description: 'aria label for modal title',
},
});
class AudioModal extends Component {
@ -452,6 +456,7 @@ class AudioModal extends Component {
className={styles.modal}
onRequestClose={closeModal}
hideBorder
contentLabel={intl.formatMessage(intlMessages.ariaModalTitle)}
>
{!this.skipAudioOptions()

View File

@ -50,6 +50,10 @@ const intlMessages = defineMessages({
id: 'app.lock-viewers.PrivateChatLable',
description: 'description for close button',
},
ariaModalTitle: {
id: 'app.lock-viewers.ariaTitle',
description: 'aria label for modal title',
},
});
class LockViewersComponent extends React.PureComponent {
@ -68,11 +72,12 @@ class LockViewersComponent extends React.PureComponent {
className={styles.modal}
onRequestClose={closeModal}
hideBorder
contentLabel={intl.formatMessage(intlMessages.ariaModalTitle)}
>
<div className={styles.container}>
<div className={styles.header}>
<div className={styles.title}>{intl.formatMessage(intlMessages.lockViewersTitle)}</div>
<h2 className={styles.title}>{intl.formatMessage(intlMessages.lockViewersTitle)}</h2>
</div>
<div className={styles.description}>
{`${intl.formatMessage(intlMessages.lockViewersDescription)}`}

View File

@ -78,6 +78,7 @@ class RecordingComponent extends React.PureComponent {
className={styles.modal}
onRequestClose={closeModal}
hideBorder
contentLabel={title}
>
<div className={styles.container}>
<div className={styles.header}>

View File

@ -340,6 +340,7 @@
"app.breakoutTimeRemainingMessage": "Breakout room time remaining: {0}",
"app.breakoutWillCloseMessage": "Time ended. Breakout room will close soon",
"app.calculatingBreakoutTimeRemaining": "Calculating remaining time ...",
"app.audioModal.ariaTitle": "Join audio modal",
"app.audioModal.microphoneLabel": "Microphone",
"app.audioModal.listenOnlyLabel": "Listen only",
"app.audioModal.audioChoiceLabel": "How would you like to join the audio?",
@ -450,6 +451,7 @@
"app.lock-viewers.PublicChatLabel": "Public chat",
"app.lock-viewers.PrivateChatLable": "Private chat",
"app.lock-viewers.Layout": "Layout",
"app.lock-viewers.ariaTitle": "Lock viewers modal",
"app.recording.startTitle": "Start recording",
"app.recording.stopTitle": "Pause recording",
"app.recording.resumeTitle": "Resume recording",