BigBlueButton/bigbluebutton-Github
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: adjust inline comment for packet loss metric usage

Browse Source 
Adjust an inline comment in connection status' service about packet loss metric
usage.

Now it correctly states that the absolute counter SHOULD NOT be used for
alert triggers.
This commit is contained in:
Paulo Lanzarin 2024-08-29 15:53:03 -03:00 committed by GitHub
parent 1eafe4b621
commit 3fbe4be441
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
bigbluebutton-html5/imports/ui/components/connection-status/service.js
View File

@ -69,8 +69,8 @@ export const handleAudioStatsEvent = (event) => {
//
// This metric is DIFFERENT from the one used in the connection status modal
// (see the network data object in this file). The network data one is an
// absolute counter of INBOUND packets lost - and it should be used to determine
// alert triggers
// absolute counter of INBOUND packets lost - and it *SHOULD NOT* be used to
// determine alert triggers
connectionStatus.setPacketLossStatus(
getStatus(window.meetingClientSettings.public.stats.loss, loss),
);