BigBlueButton/bigbluebutton-Github
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #16005 from JoVictorNunes/fix-console-warnings

Browse Source 
fix: console warnings due to invalid attributes
This commit is contained in:
Ramón Souza 2022-11-18 13:24:55 -03:00 committed by GitHub
commit 330c5e9b94
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
bigbluebutton-html5/imports/ui/components/common/modal/header/component.jsx
View File

@ -46,15 +46,15 @@ class Header extends React.Component {
return (
<Styled.Header
hideBorder={hideBorder}
headerOnTop={headerOnTop}
innerHeader={innerHeader}
$hideBorder={hideBorder}
$headerOnTop={headerOnTop}
$innerHeader={innerHeader}
{...other}
>
<Styled.Title
hasMarginBottom={innerHeader}
headerOnTop={headerOnTop}
innerHeader={innerHeader}
$hasMarginBottom={innerHeader}
$headerOnTop={headerOnTop}
$innerHeader={innerHeader}
>
{children}
</Styled.Title>
@ -65,8 +65,8 @@ class Header extends React.Component {
circle
hideLabel
aria-describedby="modalDismissDescription"
headerOnTop={headerOnTop}
innerHeader={innerHeader}
$headerOnTop={headerOnTop}
$innerHeader={innerHeader}
{...closeButtonProps}
/>
) : null}

22
bigbluebutton-html5/imports/ui/components/common/modal/header/styles.js
View File

@ -24,17 +24,17 @@ const Header = styled.header`
border: none;
display: grid;
${({ headerOnTop }) => headerOnTop && `
grid-template-columns: auto max-content;
${({ $headerOnTop }) => $headerOnTop && `
grid-template-columns: auto min-content;
grid-template-rows: min-content;
`}
${({ innerHeader }) => innerHeader && `
${({ $innerHeader }) => $innerHeader && `
grid-template-columns: auto;
grid-template-rows: min-content min-content;
`}
${({ hideBorder }) => !hideBorder && `
${({ $hideBorder }) => !$hideBorder && `
padding: calc(${lineHeightComputed} / 2) 0;
border-bottom: ${borderSize} solid ${colorGrayLighter};
`}
@ -55,15 +55,15 @@ const Title = styled(TitleElipsis)`
padding: 0 ${mdPaddingX};
}
${({ headerOnTop }) => headerOnTop && `
${({ $headerOnTop }) => $headerOnTop && `
grid-area: 1 / 1 / 2 / 3;
`}
${({ innerHeader }) => innerHeader && `
grid-area: 2 / 1 / 3 / 3;
${({ $innerHeader }) => $innerHeader && `
grid-area: 2 / 1 / 3 / 2;
`}
${({ hasMarginBottom }) => hasMarginBottom && `
${({ $hasMarginBottom }) => $hasMarginBottom && `
margin-bottom: ${mdPaddingX};
`}
`;
@ -76,12 +76,12 @@ const DismissButton = styled(Button)`
& > i { color: ${colorText}; }
}
${({ headerOnTop }) => headerOnTop && `
${({ $headerOnTop }) => $headerOnTop && `
grid-area: 1 / 2 / 2 / 3;
`}
${({ innerHeader }) => innerHeader && `
grid-area: 1 / 1 / 2 / 3;
${({ $innerHeader }) => $innerHeader && `
grid-area: 1 / 1 / 2 / 2;
`}
justify-self: end;