BigBlueButton/bigbluebutton-Github
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(layout): correct top and height calculation of camera dock bounds

Browse Source 
Fixes an issue with the camera dock bounds calculation, where the banner
height was being accounted for twice, leading to incorrect dock height
and excessive spacing. The height is now correctly based on the media
are height, which already factors in the banner height.

Additionally, the top position of the camera dock is now calculated
using the media area's top position, correctly factoring in the margin of
the media area.
This commit is contained in:
Arthurk12 2024-10-09 15:05:56 -03:00
parent a0f1039721
commit 28eb37a498
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
bigbluebutton-html5/imports/ui/components/layout/layout-manager/layoutEngine.jsx
View File

@ -69,7 +69,6 @@ const LayoutEngine = () => {
return cameraDockBounds;
}
const navBarHeight = calculatesNavbarHeight();
const hasPresentation = isPresentationEnabled && slidesLength !== 0;
const isGeneralMediaOff = !hasPresentation
&& !hasExternalVideo && !hasScreenShare
@ -78,9 +77,9 @@ const LayoutEngine = () => {
if (!isOpen || isGeneralMediaOff) {
cameraDockBounds.width = mediaAreaBounds.width;
cameraDockBounds.maxWidth = mediaAreaBounds.width;
cameraDockBounds.height = mediaAreaBounds.height - bannerAreaHeight();
cameraDockBounds.height = mediaAreaBounds.height;
cameraDockBounds.maxHeight = mediaAreaBounds.height;
cameraDockBounds.top = navBarHeight + bannerAreaHeight();
cameraDockBounds.top = mediaAreaBounds.top;
cameraDockBounds.left = !isRTL ? mediaAreaBounds.left : 0;
cameraDockBounds.right = isRTL ? sidebarSize : null;
}