BigBlueButton/bigbluebutton-Github
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

recording: work around invalid locale in caption events (#19682)

Browse Source 
This is a workaround for #19178 - but it does not fix the issue. The
caption recording events with invalid empty `<locale/>` are simply
dropped with a warning message, to allow the recording and any valid
caption streams present to be processed.

Co-authored-by: Calvin Walton <calvin.walton@blindsidenetworks.com>
This commit is contained in:
Anton Georgiev 2024-02-23 20:59:34 -05:00 committed by GitHub
parent aacf4ed263
commit 23ea53e452
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
record-and-playback/core/scripts/utils/gen_webvtt
View File

@ -383,6 +383,11 @@ def parse_events(directory="."):
have_record_events = True have_record_events = True
elif name == "EditCaptionHistoryEvent": elif name == "EditCaptionHistoryEvent":
parse_caption_edit(event, element) parse_caption_edit(event, element)
if event["locale"] is None:
logger.warn(
"Skipping invalid caption event with unset locale. See https://github.com/bigbluebutton/bigbluebutton/issues/19178 for details"
)
continue
else: else:
logger.debug("Unhandled event: %s", name) logger.debug("Unhandled event: %s", name)
continue continue