BigBlueButton/bigbluebutton-Github
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: undefined accesses causes crashes in actions-bar breakout utils

Browse Source 
Multiple undefined accesses in actions-bar's service, mainly related to
breakouts and ageneral Meetings info, cause crashes in production
environments - most likely in reconnection scenarios.

Guarantee that nested data is safely accessed.
This commit is contained in:
prlanzarin 2024-04-30 14:40:28 -03:00
parent be96230894
commit 2084392ac7
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
bigbluebutton-html5/imports/ui/components/actions-bar/service.js
View File

@ -61,15 +61,15 @@ export default {
}, },
}), }),
meetingName: () => Meetings.findOne({ meetingId: Auth.meetingID }, meetingName: () => Meetings.findOne({ meetingId: Auth.meetingID },
{ fields: { 'meetingProp.name': 1 } }).meetingProp.name, { fields: { 'meetingProp.name': 1 } })?.meetingProp?.name,
users: () => Users.find({ users: () => Users.find({
meetingId: Auth.meetingID, meetingId: Auth.meetingID,
clientType: { $ne: DIAL_IN_USER }, clientType: { $ne: DIAL_IN_USER },
}).fetch(), }).fetch(),
groups: () => Meetings.findOne({ meetingId: Auth.meetingID }, groups: () => Meetings.findOne({ meetingId: Auth.meetingID },
{ fields: { groups: 1 } }).groups, { fields: { groups: 1 } })?.groups,
isBreakoutRecordable: () => Meetings.findOne({ meetingId: Auth.meetingID }, isBreakoutRecordable: () => Meetings.findOne({ meetingId: Auth.meetingID },
{ fields: { 'breakoutProps.record': 1 } }).breakoutProps.record, { fields: { 'breakoutProps.record': 1 } })?.breakoutProps?.record,
toggleRecording: () => makeCall('toggleRecording'), toggleRecording: () => makeCall('toggleRecording'),
createBreakoutRoom: (rooms, durationInMinutes, record = false, captureNotes = false, captureSlides = false, sendInviteToModerators = false) => makeCall('createBreakoutRoom', rooms, durationInMinutes, record, captureNotes, captureSlides, sendInviteToModerators), createBreakoutRoom: (rooms, durationInMinutes, record = false, captureNotes = false, captureSlides = false, sendInviteToModerators = false) => makeCall('createBreakoutRoom', rooms, durationInMinutes, record, captureNotes, captureSlides, sendInviteToModerators),
sendInvitation: (breakoutId, userId) => makeCall('requestJoinURL', { breakoutId, userId }), sendInvitation: (breakoutId, userId) => makeCall('requestJoinURL', { breakoutId, userId }),