BigBlueButton/bigbluebutton-Github
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #20012 from prlanzarin/u27/fix/arthurk12-screenreader-crash

Browse Source 
[2.7] fix(screen-reader): add safeguards for adding alerts
This commit is contained in:
Anton Georgiev 2024-04-12 15:33:28 -04:00 committed by GitHub
commit 10cb2f3875
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
bigbluebutton-html5/imports/ui/components/screenreader-alert/component.jsx
View File

@ -9,7 +9,10 @@ const ScreenReaderAlert = ({ olderAlert }) => {
if (olderAlert) setTimeout(() => removeAlert(olderAlert.id), ARIA_ALERT_EXT_TIMEOUT);
}, [olderAlert?.id]);
return olderAlert ? createPortal(olderAlert.text, document.getElementById('aria-polite-alert')) : null;
const ariaAlertsElement = document.getElementById('aria-polite-alert');
const shouldAddAlert = olderAlert && olderAlert.text && ariaAlertsElement !== null;
return shouldAddAlert ? createPortal(olderAlert.text, ariaAlertsElement) : null;
};
export default ScreenReaderAlert;