test: Update test steps that frequently fail in CI (#21267)

- Share camera: removes unnecessary check for "connecting" element;
- Send presentation with annotation: Removes check for toast notification after sending the file - doesn't show anymore
- Zoom: bug spotted. test flagged as flaky and issue opened + linked
This commit is contained in:
Anton Barboza de Sá 2024-09-26 10:51:00 -03:00 committed by GitHub
parent 35c29836b2
commit 04b86c12a9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 5 deletions

View File

@ -41,9 +41,6 @@ class Presentation extends MultiUsers {
await this.modPage.waitAndClick(e.shareCameraAsContent);
await this.modPage.hasElement(e.videoPreview, 'should display the camera preview when sharing camera as content');
await this.modPage.waitAndClick(e.startSharingWebcam);
await this.modPage.hasElement(e.screenshareConnecting);
await this.modPage.wasRemoved(e.screenshareConnecting);
await this.modPage.hasElement(e.screenShareVideo);
// close all notifications displayed before comparing screenshots
for (const closeButton of await this.modPage.getLocator(e.closeToastBtn).all()) {
@ -320,7 +317,6 @@ class Presentation extends MultiUsers {
}
await this.modPage.waitAndClick(e.sendPresentationInCurrentStateBtn);
await this.modPage.hasElement(e.downloadPresentationToast);
await this.modPage.hasElement(e.smallToastMsg, 20000);
await this.userPage.hasElement(e.downloadPresentation, ELEMENT_WAIT_EXTRA_LONG_TIME);
const downloadPresentationLocator = this.userPage.getLocator(e.downloadPresentation);
await this.userPage.handleDownload(downloadPresentationLocator, testInfo);

View File

@ -59,7 +59,8 @@ test.describe.parallel('Presentation', () => {
await presentation.hidePresentationToolbar();
});
test('Zoom In, Zoom Out, Reset Zoom', { tag: '@ci' }, async ({ browser, context, page }) => {
test('Zoom In, Zoom Out, Reset Zoom', { tag: ['@ci', '@flaky'] }, async ({ browser, context, page }) => {
// @flaky: see https://github.com/bigbluebutton/bigbluebutton/issues/21266
const presentation = new Presentation(browser, context);
await presentation.initPages(page);
await presentation.zoom();