BigBlueButton/bigbluebutton-Github
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(audio): check for session availability on exitAudio

Browse Source 
Mostly benign, but exitAudio/forceExitAudio was throwing an unhandled
error when called on sessions with no active audio because the
underlying bridge methods did not check whether there was an active
session to stop beforehand.
This commit is contained in:
prlanzarin 2022-10-27 16:13:27 +00:00
parent 32734586fb
commit 031bedf3ca
3 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
bigbluebutton-html5/imports/api/audio/client/bridge/FullAudioBridge.js
View File

@ -413,8 +413,11 @@ export default class FullAudioBridge extends BaseAudioBridge {
const mediaElement = document.getElementById(MEDIA_TAG);
this.clearReconnectionTimeout();
this.broker.stop();
this.broker = null;
if (this.broker) {
this.broker.stop();
this.broker = null;
}
if (mediaElement && typeof mediaElement.pause === 'function') {
mediaElement.pause();

2
bigbluebutton-html5/imports/api/audio/client/bridge/kurento.js
View File

@ -297,7 +297,7 @@ export default class KurentoAudioBridge extends BaseAudioBridge {
exitAudio() {
const mediaElement = document.getElementById(MEDIA_TAG);
this.broker.stop();
if (this.broker) this.broker.stop();
this.clearReconnectionTimeout();
if (mediaElement && typeof mediaElement.pause === 'function') {

2
bigbluebutton-html5/imports/api/audio/client/bridge/sip.js
View File

@ -1375,6 +1375,8 @@ export default class SIPBridge extends BaseAudioBridge {
}
exitAudio() {
if (this.activeSession == null) return Promise.resolve();
return this.activeSession.exitAudio();
}